Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove special-cased algorithm selection for CUDNN convolution #703

Merged
merged 1 commit into from
Feb 10, 2021

Conversation

denizyuret
Copy link
Contributor

@denizyuret denizyuret commented Feb 10, 2021

Fixes #702

Removes the special-case algorithm selection based on the second note in https://docs.nvidia.com/deeplearning/cudnn/api/index.html#cudnnConvolutionBiasActivationForward. Maybe there was something wrong with the struct here,

cudnnConvolutionFwdAlgoPerf_t(algo, CUDNN_STATUS_SUCCESS, Cfloat(0), memory, CUDNN_NON_DETERMINISTIC, math_mode(), Cint.((0,0,0)))
.

@maleadt maleadt added bugfix This gets something working again. cuda libraries Stuff about CUDA library wrappers. labels Feb 10, 2021
@maleadt maleadt changed the title fix #702: cudnnConvolutionForward fails memory checking Remove special-cased algorithm selection for CUDNN convolution Feb 10, 2021
@maleadt maleadt merged commit 8888c55 into JuliaGPU:master Feb 10, 2021
maleadt added a commit that referenced this pull request Feb 10, 2021
Remove special-cased algorithm selection for CUDNN convolution
maleadt added a commit that referenced this pull request Mar 16, 2021
Remove special-cased algorithm selection for CUDNN convolution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This gets something working again. cuda libraries Stuff about CUDA library wrappers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cudnnConvolutionForward fails memory checking
2 participants