Keep track of active handles to avoid early collection. #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maleadt
added
bugfix
maleadt
force-pushed
the
tb/gc_handle_cache
branch
3 times, most recently
from
e7625e4
to
90a52e8
Compare
Also make sure accesses to old handles is thread-safe.
maleadt
force-pushed
the
tb/gc_handle_cache
branch
from
90a52e8
to
a85029d
Compare
|
Yes. this fixed the curand issue. The code in #699 passed. Many thanks. |
Codecov Report
@@ Coverage Diff @@
## master #704 +/- ##
==========================================
- Coverage 79.65% 79.60% -0.05%
==========================================
Files 122 122
Lines 7352 7374 +22
==========================================
+ Hits 5856 5870 +14
- Misses 1496 1504 +8
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #699.
@norci could you test?