Flip exception_flag filter! predicate #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maleadt
reviewed
Feb 16, 2021
julia> external_gvars = ["exception_flag", "other_flag", "another_flag"]
3-element Vector{String}:
"exception_flag"
"other_flag"
"another_flag"
julia> filter!(isequal("exception_flag"), external_gvars)
1-element Vector{String}:
"exception_flag"
julia> external_gvars = ["exception_flag", "other_flag", "another_flag"]
3-element Vector{String}:
"exception_flag"
"other_flag"
"another_flag"
julia> filter!(x -> x != "exception_flag", external_gvars)
2-element Vector{String}:
"other_flag"
"another_flag"
Codecov Report
@@ Coverage Diff @@
## master #717 +/- ##
=======================================
Coverage 79.88% 79.88%
=======================================
Files 122 122
Lines 7388 7388
=======================================
Hits 5902 5902
Misses 1486 1486
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this while adding other externally initialized global variables. It was very confusing to not see them show up in
external_gvars.