Keep some memory reserved for external allocations. #718
Conversation
Codecov Report
@@ Coverage Diff @@
## master #718 +/- ##
==========================================
- Coverage 79.88% 76.71% -3.17%
==========================================
Files 122 122
Lines 7388 7714 +326
==========================================
+ Hits 5902 5918 +16
- Misses 1486 1796 +310
Continue to review full report at Codecov.
|
maleadt
force-pushed
the
tb/reserve_memory
branch
from
1cfd96d
to
8ec0a33
Compare
|
cc @denizyuret @DhairyaLGandhi @jonathan-laurent; these changes should make CUDNN less likely to crash when close to OOM, at the expense of some additional memory pressure. Please report back if you'd see excessive GC memory times on Another part of the puzzle is #679, and I hope the combination of these two changes to make a serious dent in the memory management issue. What remains then is making the Julia GC free memory a little more often, but that's a much bigger change. |
|
Anecdotally, it seems to have helped, but I don't have enough "before" numbers to say empirically. |
This PR splits the memory limit into a 'soft' and 'hard' limit, where the soft limit tries to keep a chunk of memory available for external libraries like CUDNN or CUBLAS. This should reduce the change of running into bad error situations that are often caused by an OOM but not reported as such. If it isn't possible to stick to the soft memory limit (i.e, after calling the GC a couple of times) we'll use the hard limit which is allowed to eat into the memory reserve up to any user-imposed memory limit.