Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Abstract FFT compat #721

Merged
merged 2 commits into from
Feb 19, 2021
Merged

Add Abstract FFT compat #721

merged 2 commits into from
Feb 19, 2021

Conversation

DhairyaLGandhi
Copy link
Member

No description provided.

@DilumAluthge
Copy link
Contributor

@DhairyaLGandhi If you haven't done so already, you should probably make a similar PR to GPUArrays.jl.

@maleadt
Copy link
Member

maleadt commented Feb 19, 2021

It's always good to bump the package in the Manifest too so that the CI run is meaningful.

@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #721 (49a5cd1) into compat (02ac36a) will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           compat     #721      +/-   ##
==========================================
- Coverage   77.27%   77.12%   -0.16%     
==========================================
  Files         116      116              
  Lines        6438     6438              
==========================================
- Hits         4975     4965      -10     
- Misses       1463     1473      +10     
Impacted Files Coverage Δ
lib/library_types.jl 18.18% <0.00%> (-8.09%) ⬇️
src/utilities.jl 90.16% <0.00%> (-1.64%) ⬇️
lib/cublas/wrappers.jl 90.57% <0.00%> (-0.43%) ⬇️
src/pool.jl 72.50% <0.00%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02ac36a...49a5cd1. Read the comment docs.

@maleadt maleadt merged commit d69be98 into JuliaGPU:compat Feb 19, 2021
maleadt added a commit that referenced this pull request Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants