Specialize Base.to_index for AnyCuArray{Bool} #724
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #106 and fixes #131. It is not he most performant solution as discussed in #131.
Probably a better solution would be to revert this
Base.to_index
specialization, check if there areLogicalIndex
es among the results ofto_indicices
insetindex!(::CuArray, ...)
, and have a specialized kernel for_setindex!
andLogicalIndex
in GPUArrays.jl, but I guess that can be improved later.@maleadt