Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eagerly dlopen cublasLt to prevent a system library getting picked up. #729

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Eagerly dlopen cublasLt to prevent a system library getting picked up. #729

merged 1 commit into from
Feb 22, 2021

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Feb 22, 2021

Maybe fixes #609.

@maleadt maleadt added bug Something isn't working installation CUDA is easy to install, right? labels Feb 22, 2021
@maleadt maleadt mentioned this pull request Feb 22, 2021
Closed
@codecov
Copy link

codecov bot commented Feb 22, 2021 •
edited

Codecov Report

Merging #729 (b847235) into master (a34e69e) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #729      +/-   ##
==========================================
- Coverage   79.91%   79.90%   -0.02%     
==========================================
  Files         122      122              
  Lines        7405     7405              
==========================================
- Hits         5918     5917       -1     
- Misses       1487     1488       +1
Impacted Files Coverage Δ
src/pool.jl 73.46% <0.00%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a34e69e...b847235. Read the comment docs.

@jonathan-laurent
Copy link

This PR fixes my CUBLAS tests and the various "missing symbol" errors I had encountered.

@maleadt
Copy link
Member Author

maleadt commented Feb 22, 2021

Great! Thanks for confirming.

@maleadt maleadt merged commit 99d8c4c into master Feb 22, 2021
@maleadt maleadt deleted the tb/dlopen_cublaslt branch February 22, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working installation CUDA is easy to install, right?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gemmEx on sm_52 results in CUBLAS_STATUS_ARCH_MISMATCH
2 participants
@maleadt @jonathan-laurent