You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some performance (inferability) fixes, but also some bug fixes where we didn't switch to the appropriate context from finalizers. This would only surface in a multi-device setting (cc @marius311, in case you're still trying to do multi-device work in a single process).
The call to is_pinned generates a 'failure' for every memory copy.
Enabling CUTENSOR tests causes some downstream failures in _other_
CUTENSOR tests though, so disable those (pinned memory) tests.
So funnily enough the very first thing I ran with this PR I saw finalizer error, then haven't been able to reproduce in an ~hour of some farily complicated stuff. So maybe there's still an edge case out there, but overall definitely seems like an improvement, thanks!
I've been seeing some other finalizer errors on CI too, it's always CUDA.cudaError_enum(0x000002c5) which indicates an API call after the context has been destroyed. That only ever can happen at process exit, so it probably doesn't actually hurt, but I'd like to find the source of it of course. So if you know how to reproduce, or even have some vague ideas about it, please let me know.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maleadt
added
enhancement
Some performance (inferability) fixes, but also some bug fixes where we didn't switch to the appropriate context from finalizers. This would only surface in a multi-device setting (cc @marius311, in case you're still trying to do multi-device work in a single process).