Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #849, allow CUSPARSE to use F16 #904

Merged
merged 4 commits into from May 17, 2021
Merged

Fix #849, allow CUSPARSE to use F16 #904

merged 4 commits into from May 17, 2021

Conversation

kshyatt
Copy link
Contributor

@kshyatt kshyatt commented May 12, 2021

Needs tests but cyclops was broken.

@kshyatt kshyatt added needs tests Tests are requested. cuda libraries Stuff about CUDA library wrappers. labels May 12, 2021
@kshyatt kshyatt marked this pull request as ready for review May 13, 2021 17:34
@kshyatt kshyatt requested a review from maleadt May 13, 2021 17:34
@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #904 (5f4dc13) into master (182a5a8) will decrease coverage by 0.34%.
The diff coverage is 55.92%.

❗ Current head 5f4dc13 differs from pull request most recent head 77c46f9. Consider uploading reports for the commit 77c46f9 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #904      +/-   ##
==========================================
- Coverage   77.27%   76.92%   -0.35%     
==========================================
  Files         121      121              
  Lines        7564     7702     +138     
==========================================
+ Hits         5845     5925      +80     
- Misses       1719     1777      +58     
Impacted Files Coverage Δ
lib/cusparse/interfaces.jl 62.96% <ø> (ø)
lib/cusparse/conversions.jl 63.06% <36.58%> (-16.35%) ⬇️
lib/cublas/wrappers.jl 89.48% <73.21%> (-1.12%) ⬇️
lib/cublas/linalg.jl 87.87% <100.00%> (ø)
lib/cusparse/generic.jl 94.05% <100.00%> (+0.37%) ⬆️
lib/cusolver/CUSOLVER.jl 82.00% <0.00%> (-1.34%) ⬇️
src/array.jl 85.54% <0.00%> (+0.39%) ⬆️
lib/library_types.jl 20.00% <0.00%> (+1.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28f7e49...77c46f9. Read the comment docs.

lib/cublas/wrappers.jl Outdated Show resolved Hide resolved
lib/cublas/util.jl Outdated Show resolved Hide resolved
lib/cusparse/conversions.jl Outdated Show resolved Hide resolved
lib/cusparse/generic.jl Outdated Show resolved Hide resolved
lib/cusparse/interfaces.jl Show resolved Hide resolved
@kshyatt
Copy link
Contributor Author

kshyatt commented May 17, 2021

CI failed due to a weird end of instruction error.

@maleadt
Copy link
Member

maleadt commented May 17, 2021

Yeah, JuliaLang/julia#39865. I've set it to allow-failure on master, but let's just go ahead and merge this.

@maleadt maleadt merged commit eca328f into master May 17, 2021
@maleadt maleadt deleted the ksh/sparsef16 branch May 17, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda libraries Stuff about CUDA library wrappers. needs tests Tests are requested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants