Skip to content
This repository has been archived by the owner on Mar 12, 2021. It is now read-only.

NNlib batched_mul! #619

Merged
merged 5 commits into from Mar 10, 2020
Merged

NNlib batched_mul! #619

merged 5 commits into from Mar 10, 2020

Conversation

mcabbott
Copy link

@mcabbott mcabbott commented Mar 5, 2020

This hooks up FluxML/NNlib.jl#100 for CuArrays.

I've added an extremely simple test, but could find the right place to insert this into test/blas.jl perhaps if that would be better?

Tests fail locally, before this PR, but I'm not sure why.

I think that _GemmFloat == CUBLAS.CublasFloat, except that this isn't loaded yet. Is there a neater way?

@maleadt
Copy link
Member

maleadt commented Mar 9, 2020

I've added an extremely simple test, but could find the right place to insert this into test/blas.jl perhaps if that would be better?

It's an nnlib specific interface, so that place seems fine.

Tests fail locally, before this PR, but I'm not sure why.

Please open an issue for that then. Let's see what CI does here:
bors try

I think that _GemmFloat == CUBLAS.CublasFloat, except that this isn't loaded yet. Is there a neater way?

Move the include of nnlib.jl until after the submodules (including CUBLAS)?

bors bot added a commit that referenced this pull request Mar 9, 2020
@bors
Copy link
Contributor

bors bot commented Mar 9, 2020

try

Build succeeded

@mcabbott
Copy link
Author

Thanks for having a look, I've moved the include("nnlib.jl") as suggested.

About tests, is there a list of what needs to be on master? I failed again, but can try more seriously once back in front of my desktop, probably in 2 weeks.

@maleadt
Copy link
Member

maleadt commented Mar 10, 2020

About tests, is there a list of what needs to be on master? I failed again, but can try more seriously once back in front of my desktop, probably in 2 weeks.

Generally CuArrays, CUDAnative, CUDAdrv and GPUArrays. CuArrays also ships a Manifest with a known-good combination, so you can just clone CuArrays and run with julia --project in that dir.

@maleadt
Copy link
Member

maleadt commented Mar 10, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 10, 2020

Build succeeded

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants