This repository has been archived by the owner on Nov 18, 2020. It is now read-only.
Revisions to wrappers pt 1 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpsamaroo
approved these changes
Apr 16, 2020
wsphillips
force-pushed
the
wsp/wrapremix2
branch
from
244ed3f
to
7b9c98c
Compare
|
Not sure what's up with CI; let's give it a kick. |
|
I'll merge this now so we can get the matching AMDGPUnative PR tests going, and then correct any issues after the fact. |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft is the first in a sequence of hygeine revisions planned to make HSARuntime.jl more easily debugged and readable, as well as making our wrappers more consistent with changes that have accumulated over time in the HSA C API.
I regenerated wrappers using a more recent version of the HSA headers, automating (most) of the heavy lifting. Aside from naming convention changes, this revision packs everything in the HSA C api into a sumodule
HSA. Therefore, there's a clear boundary between high-level functions we create and what's pulling from C. Low-level function wrappers are now more strictly typed. The exported API remains unchanged. This passes tests locally and with some minor tweaks to AMDGPUnative, the compiler is happy too.