New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull @unroll
out into its own tiny package
#199
Comments
I am not a fan of tiny packages ;) But you have my encouragement to upstream it JuliaLang/julia#31376 |
Do you mind if I rebase the branch in JuliaLang/julia#31376? And push some more commits to that branch? |
Please go ahead.
…On Tue, Jan 12, 2021 at 3:37 PM Dilum Aluthge ***@***.***> wrote:
Do you mind if I rebase the branch in JuliaLang/julia#31376
<JuliaLang/julia#31376>? And push some more
commits to that branch?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#199 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABDO2XYMJORLE3H4H3HIG3SZSXIZANCNFSM4V5RXDSA>
.
|
Who do you think the right people are to review that PR? |
Jeff/Keno/Jameson/Yichao/Tim B./Me but the reason I never finished it was because I never came up wit a composable user interface, that should also incorporate parts of |
Maybe we shouldn't let the perfect get it the way of the good :) I think it would be very useful to provide the functionality of the PR to users - be it in a package or in form of a revised PR. |
Wanna create a small package at JuliaPerf with that? |
The
@unroll
macro used to live in GPUifyLoops.jl. Now it lives in theextras
folder of KernelAbstractions.jl.It doesn't seem like the
@unroll
functionality depends on anything else in KernelAbstractions. Would it be okay if I pulled it out into its own small package?E.g. GEMMKernels.jl uses
@unroll
but nothing else - no need to make GEMMKernels load all of KernelAbstractions if it only needs@unroll
.The text was updated successfully, but these errors were encountered: