Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull @unroll out into its own tiny package #199

Open
DilumAluthge opened this issue Jan 11, 2021 · 7 comments
Open

Pull @unroll out into its own tiny package #199

DilumAluthge opened this issue Jan 11, 2021 · 7 comments

Comments

@DilumAluthge
Copy link
Collaborator

The @unroll macro used to live in GPUifyLoops.jl. Now it lives in the extras folder of KernelAbstractions.jl.

It doesn't seem like the @unroll functionality depends on anything else in KernelAbstractions. Would it be okay if I pulled it out into its own small package?

E.g. GEMMKernels.jl uses @unroll but nothing else - no need to make GEMMKernels load all of KernelAbstractions if it only needs @unroll.

@vchuravy
Copy link
Member

I am not a fan of tiny packages ;)

But you have my encouragement to upstream it JuliaLang/julia#31376

@DilumAluthge
Copy link
Collaborator Author

Do you mind if I rebase the branch in JuliaLang/julia#31376? And push some more commits to that branch?

@vchuravy
Copy link
Member

vchuravy commented Jan 12, 2021 via email

@DilumAluthge
Copy link
Collaborator Author

Who do you think the right people are to review that PR?

@vchuravy
Copy link
Member

vchuravy commented Jan 12, 2021

Jeff/Keno/Jameson/Yichao/Tim B./Me but the reason I never finished it was because I never came up wit a composable user interface, that should also incorporate parts of @simd

@carstenbauer
Copy link
Member

Jeff/Keno/Jameson/Yichao/Tim B./Me but the reason I never finished it was because I never came up wit a composable user interface, that should also incorporate parts of @simd

Maybe we shouldn't let the perfect get it the way of the good :) I think it would be very useful to provide the functionality of the PR to users - be it in a package or in form of a revised PR.

@vchuravy
Copy link
Member

vchuravy commented Jul 4, 2023

Wanna create a small package at JuliaPerf with that?
I do think it's worth finding out a good user interface, but the burden of contribution is higher in base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants