Address review comments

JuliaGPU · May 24, 2024 · 32057c1 · 32057c1
1 parent 8b1f274
commit 32057c1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/docs/src/usage/array.md b/docs/src/usage/array.md
@@ -149,4 +149,4 @@ julia> a = Random.rand!(GPUArrays.default_rng(MtlArray), a)
     `MPSMatrixRandom` functionality requires Metal.jl > v1.1
 
 !!! warning
-    `Random.rand!(::MPS.RNG, args...)` andc `Random.randn!(::MPS.RNG, args...)` have a framework limitation that requires the byte offset and byte size of the destination array to be a multiple of 4.
+    `Random.rand!(::MPS.RNG, args...)` and `Random.randn!(::MPS.RNG, args...)` have a framework limitation that requires the byte offset and byte size of the destination array to be a multiple of 4.
diff --git a/lib/mps/matrixrandom.jl b/lib/mps/matrixrandom.jl
@@ -24,7 +24,7 @@ end
 function MPSMatrixRandomDefaultDistributionDescriptor()
     desc = @objc [MPSMatrixRandomDistributionDescriptor defaultDistributionDescriptor]::id{MPSMatrixRandomDistributionDescriptor}
     obj = MPSMatrixRandomDistributionDescriptor(desc)
-    # XXX: who releases this object?
+    finalizer(release, obj)
     return obj
 end
 
@@ -35,7 +35,6 @@ function MPSMatrixRandomNormalDistributionDescriptor(mean, standardDeviation)
     desc = @objc [MPSMatrixRandomDistributionDescriptor normalDistributionDescriptorWithMean:mean::Float32
                                                         standardDeviation:standardDeviation::Float32]::id{MPSMatrixRandomDistributionDescriptor}
     obj = MPSMatrixRandomDistributionDescriptor(desc)
-    # XXX: who releases this object?
     return obj
 end
 
@@ -45,15 +44,13 @@ function MPSMatrixRandomNormalDistributionDescriptor(mean, standardDeviation, mi
                                                         minimum:minimum::Float32
                                                         maximum:maximum::Float32]::id{MPSMatrixRandomDistributionDescriptor}
     obj = MPSMatrixRandomDistributionDescriptor(desc)
-    # XXX: who releases this object?
     return obj
 end
 
 function MPSMatrixRandomUniformDistributionDescriptor(minimum, maximum)
     desc = @objc [MPSMatrixRandomDistributionDescriptor uniformDistributionDescriptorWithMinimum:minimum::Float32
                                                         maximum:maximum::Float32]::id{MPSMatrixRandomDistributionDescriptor}
     obj = MPSMatrixRandomDistributionDescriptor(desc)
-    # XXX: who releases this object?
     return obj
 end