Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reductions don't work on Shared Arrays #312

Closed
tgymnich opened this issue Mar 11, 2024 · 1 comment · Fixed by #314
Closed

Reductions don't work on Shared Arrays #312

tgymnich opened this issue Mar 11, 2024 · 1 comment · Fixed by #314
Labels
bug Something isn't working

Comments

@tgymnich
Copy link
Member

tgymnich commented Mar 11, 2024

using Metal

a = mtl(rand(10_240_000), storage=Shared)
julia> sum(a)
0.0f0`

The issue might be caused by #305

==> missing sync in Base.unsafe_convert(::Type{Ptr{S}}, x::MtlArray{T}) where {S, T}

@maleadt
Copy link
Member

maleadt commented Mar 11, 2024

Might be good to add a CI job using another default memory type, like in CUDA.jl: https://github.com/JuliaGPU/CUDA.jl/blob/2783c88088cda38c9abec8969078344eb6fca510/.buildkite/pipeline.yml#L74-L100

@maleadt maleadt added the bug Something isn't working label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants