Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix argument types in sincos #232

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Fix argument types in sincos #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f91142
fix: sincos ccall types
fjebaker Aug 1, 2023
fb5a33c
test: added test for sincos intrinsic
fjebaker Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions src/device/intrinsics/math.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,21 @@ using Base: FastMath
@device_override Base.sin(x::Float32) = ccall("extern air.sin.f32", llvmcall, Cfloat, (Cfloat,), x)
@device_override Base.sin(x::Float16) = ccall("extern air.sin.f16", llvmcall, Float16, (Float16,), x)

@device_override FastMath.sincos_fast(x::Float32) = ccall("extern air.fast_sincos.f32", llvmcall, Cfloat, (Cfloat,), x)
@device_override Base.sincos(x::Float32) = ccall("extern air.sincos.f32", llvmcall, Cfloat, (Cfloat,), x)
@device_override Base.sincos(x::Float16) = ccall("extern air.sincos.f16", llvmcall, Float16, (Float16,), x)
@device_override function FastMath.sincos_fast(x::Float32)
c = Ref{Cfloat}()
s = ccall("extern air.fast_sincos.f32", llvmcall, Cfloat, (Cfloat, Ptr{Cfloat}), x, c)
(s, c[])
end
@device_override function Base.sincos(x::Float32)
c = Ref{Cfloat}()
s = ccall("extern air.sincos.f32", llvmcall, Cfloat, (Cfloat, Ptr{Cfloat}), x, c)
(s, c[])
end
@device_override function Base.sincos(x::Float16)
c = Ref{Float16}()
s = ccall("extern air.sincos.f16", llvmcall, Float16, (Float16, Ptr{Float16}), x, c)
(s, c[])
end

@device_override FastMath.sinh_fast(x::Float32) = ccall("extern air.fast_sinh.f32", llvmcall, Cfloat, (Cfloat,), x)
@device_override Base.sinh(x::Float32) = ccall("extern air.sinh.f32", llvmcall, Cfloat, (Cfloat,), x)
Expand Down
17 changes: 17 additions & 0 deletions test/device/intrinsics.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,23 @@ end
return nothing
end
@metal intr_test2(bufferA)
synchronize()

bufferB = MtlArray{eltype(a),length(size(a)),Shared}(a)
vecB = unsafe_wrap(Vector{Float32}, pointer(bufferB), 1)

function intr_test3(arr_sin, arr_cos)
idx = thread_position_in_grid_1d()
s, c = sincos(arr_cos[idx])
arr_sin[idx] = s
arr_cos[idx] = c
return nothing
end

@metal intr_test3(bufferA, bufferB)
synchronize()
@test vecA ≈ sin.(a)
@test vecB ≈ cos.(a)
end

############################################################################################
Expand Down