Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oneMKL: support for swap #242

Merged
merged 2 commits into from
Nov 10, 2022
Merged

oneMKL: support for swap #242

merged 2 commits into from
Nov 10, 2022

Conversation

Sarbojit2019
Copy link
Contributor

No description provided.

@Sarbojit2019
Copy link
Contributor Author

Failure does not look related hence closing and re-opening to restart the build.

@Sarbojit2019 Sarbojit2019 reopened this Nov 8, 2022
@maleadt
Copy link
Member

maleadt commented Nov 8, 2022

The MKL wrapper for copy seems broken, returning all-zeros. Although not strictly related to this PR, it's related to recent oneMKL work. Could you take a look?

@Sarbojit2019
Copy link
Contributor Author

The MKL wrapper for copy seems broken, returning all-zeros. Although not strictly related to this PR, it's related to recent oneMKL work. Could you take a look?

Sure! let me check if I can reproduce the issue.

@Sarbojit2019
Copy link
Contributor Author

The MKL wrapper for copy seems broken, returning all-zeros. Although not strictly related to this PR, it's related to recent oneMKL work. Could you take a look?

Sure! let me check if I can reproduce the issue.

I can't reproduce the issue on my setup. Can we check if this is consistent?

@Sarbojit2019
Copy link
Contributor Author

@maleadt, Build is clean now, can you please take a look, if it is good to go?

@maleadt maleadt merged commit fa81e7b into JuliaGPU:master Nov 10, 2022
maleadt
maleadt reviewed Nov 10, 2022
View reviewed changes
test/onemkl.jl
oneMKL.swap!(m, dx, dy)
h_x = collect(dx)
h_y = collect(dy)
@test h_x ≈ y
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not have been an approxeq comparison

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a commit to fix this.

@maleadt maleadt mentioned this pull request Nov 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maleadt maleadt maleadt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Sarbojit2019 @maleadt