Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JLL debug mode #312

Merged
merged 5 commits into from
Apr 21, 2023
Merged

Add JLL debug mode #312

merged 5 commits into from
Apr 21, 2023

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Apr 21, 2023

This PR adds a debug mode to oneAPI.jl which currently just changes 2 JLLs to use a debug build, enabling assertions and better backtraces.

Blocked on intel/compute-runtime#639

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Patch coverage: 61.53% and project coverage change: -0.13 ⚠️

Comparison is base (e3cda8b) 85.35% compared to head (86e01db) 85.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
- Coverage   85.35%   85.23%   -0.13%     
==========================================
  Files          40       40              
  Lines        1919     1930      +11     
==========================================
+ Hits         1638     1645       +7     
- Misses        281      285       +4     
Impacted Files Coverage Δ
src/oneAPI.jl 53.33% <0.00%> (-26.67%) ⬇️
src/utils.jl 83.33% <100.00%> (+2.08%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maleadt maleadt merged commit 361f064 into master Apr 21, 2023
@maleadt maleadt deleted the tb/debug branch April 21, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant