Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the dispatch for sparse routines #410

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

amontoison
Copy link
Member

@amontoison amontoison commented Apr 2, 2024

@maleadt
Should we define AbstractoneSparseArray or AbstractOneSparseArray?

off-topic:
We have the following error when we use the artifact oneAPI_Support_jll.jl and not the local one:

INTEL MKL ERROR: /root/.cache/julia-buildkite-plugin/depots/
05c310bb-cd1d-4bbf-ad62-61f2372c55f0/artifacts/
dacc6471ef6945fc42d4c7881bb431b19e138ba3/lib/libmkl_avx512.so.2: 
cannot open shared object file: No such file or director

@amontoison amontoison requested a review from maleadt April 2, 2024 01:27
@maleadt
Copy link
Member

maleadt commented Apr 2, 2024

Should we define AbstractoneSparseArray or AbstractOneSparseArray?

Seeing how we went with oneWrappedArray, maybe oneAbstractSparseArray to preserve capitalization? In any case, neither of the options are really pleasing, I probably shouldn't have went with the lower-case one prefix (but it's what Intel does with all the oneAPI libraries, so seemed sensible).

@amontoison amontoison closed this Apr 2, 2024
@amontoison amontoison reopened this Apr 2, 2024
@amontoison
Copy link
Member Author

Thanks @maleadt!
oneAbstractSparseArray is fine for me.
I also fixed the issue with the artifact, a dependency was missing in the JLL.
All tests passed now ✔️

What do you think of a new release of oneAPI.jl after this PR?

@maleadt
Copy link
Member

maleadt commented Apr 3, 2024

What do you think of a new release of oneAPI.jl after this PR?

I was hoping to also include 1.11 support, which also requires a minor version bump.

@maleadt maleadt merged commit b6a393f into JuliaGPU:master Apr 3, 2024
1 check passed
@amontoison amontoison deleted the sparse_dispatch branch April 3, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants