-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update examples #93
Update examples #93
Conversation
Maybe it would be best to merge the MCMC and VI example as well and just have one "Regression (1D)" example (similar to GPFlow) with different approaches and packages. At some point it would also be nice to use a dataset with more than 12 observations... |
I could on board with both of your above points. Are you up for tackling the merging examples one inside this PR, or would you prefer to do it separately? |
I'll merge them in this PR since one only has to copy the VI section to the other file. |
As an additional comment I saw multiple people getting confused with data having more than one feature, an example based on matrices/vector of vectors would also be great! |
This is a good point. I've opened this issue where I think that we should move the discussion to so that we can get this merged. |
Is there any easy way to view the new documentation based on these examples, or should I pull and build locally? |
I think you need to pull locally but I managed to create a PR preview for website for Franklin, maybe I can manage the same thing for documentation, but that's for another PR |
It would be possible to set up preview builds of the documentation but currently you have to build it locally. |
I opened a PR: #96 We could wait for it, then it is probably easier to review the changes here. |
Unless you are desperate to get this in quickly, I'm happy to wait. |
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
=======================================
Coverage 99.04% 99.04%
=======================================
Files 9 9
Lines 210 210
=======================================
Hits 208 208
Misses 2 2 Continue to review full report at Codecov.
|
You can view the preview here: https://juliagaussianprocesses.github.io/AbstractGPs.jl/previews/PR93/ The "Doc Preview Cleanup" error can be ignored, the action was executed since I closed the PR but no preview existed since the preview builds were just enabled. |
The other test error is unrelated, apparently the registry couldn't be updated: https://pipelines.actions.githubusercontent.com/ySlubJLjvdr8TQDQW4YMxXe3AcvOfty8lKuun5Y5P9Amwe0EiP/_apis/pipelines/1/runs/6350/signedlogcontent/3?urlExpires=2021-01-07T12%3A51%3A44.1666175Z&urlSigningMethod=HMACV1&urlSignature=c%2BFUN9SJCpe9Vwpsx8AzkdJTK5TAjihtdVR6eeI1dCU%3D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy for this to be merged whenever you're happy @devmotion . I think the language / explanation is basically fine -- we can always iterate again later if needs be.
Yes, it can definitely be improved further, I was just too tired to optimize it any further at some point. |
This PR updates the examples.
It contains the following changes:
softplus
transformation (same as GPFlow original)I tried to improve and add some more explanations but I am still not completely satisfied. In my opinion, it is also unsatisfying that the VI and MCMC example contain many duplicate parts, and even the different method sections in the MCMC example are very similar.