Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makie@0.16? #34

Closed
willtebbutt opened this issue Jan 19, 2022 · 3 comments · Fixed by #39
Closed

Makie@0.16? #34

willtebbutt opened this issue Jan 19, 2022 · 3 comments · Fixed by #39

Comments

@willtebbutt
Copy link
Member

@devmotion any idea whether there's anything in particular that needs to change in order to upgrade this package to the latest version of Makie?

@devmotion
Copy link
Member

I don't know what the breaking changes are. Seems Github disabled Compathelper, I'll run it manually and then we'll see if anything has to be fixed.

@willtebbutt
Copy link
Member Author

What went wrong in #35 that meant it neeed reverting? Tests seem to pass when I run locally.

@devmotion
Copy link
Member

The main and in fact only way to inspect if everything works is building the documentation. But in the PR it was not built with Makie 0.16 (and there was no version bump), so it was not clear if everything works as desired. I'll open a new PR with an updated Manifest when I'm back at my computer later this afternoon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants