CompatHelper: bump compat for Makie to 0.16, (keep existing compat) #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
devmotion
force-pushed
the
compathelper/new_version/2022-01-19-10-23-39-148-02902902415
branch
from
2b01690
to
8a9b983
Compare
Pull Request Test Coverage Report for Build 1717452045Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
…ep existing compat) (#36) * CompatHelper: bump compat for CairoMakie to 0.7 for package docs, (keep existing compat) * CompatHelper: bump compat for Makie to 0.16 for package test, (keep existing compat) (#37) Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org> Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #35 +/- ##
=======================================
Coverage 23.52% 23.52%
=======================================
Files 4 4
Lines 68 68
=======================================
Hits 16 16
Misses 52 52 Continue to review full report at Codecov.
|
st--
deleted the
compathelper/new_version/2022-01-19-10-23-39-148-02902902415
branch
|
This should not have been merged 🙈🙈 |
|
The documentation is not built with Makie 0.16, the Manifest has to be updated first. |
|
Additionally, the version number was not updated. |
devmotion
restored the
compathelper/new_version/2022-01-19-10-23-39-148-02902902415
branch
|
I reverted it for now. I'll fix everything later when I have access to a computer. |
Closed
devmotion
deleted the
compathelper/new_version/2022-01-19-10-23-39-148-02902902415
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
Makiepackage from0.15.2to0.15.2, 0.16.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.