Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for Makie to 0.18, (keep existing compat) #43

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Makie package from 0.15.2, 0.16, 0.17 to 0.15.2, 0.16, 0.17, 0.18.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@devmotion devmotion force-pushed the compathelper/new_version/2022-10-13-11-59-13-828-03796872553 branch from c6e4685 to c52d6ee Compare October 13, 2022 11:59
@coveralls
Copy link

coveralls commented Oct 13, 2022

Pull Request Test Coverage Report for Build 3242164020

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 23.188%

Files with Coverage Reduction New Missed Lines %
src/recipes/gpsample.jl 1 0.0%
Totals Coverage Status
Change from base Build 2287400255: -0.3%
Covered Lines: 16
Relevant Lines: 69

💛 - Coveralls

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 23.52% // Head: 23.18% // Decreases project coverage by -0.34% ⚠️

Coverage data is based on head (6e2c54c) compared to base (fe6b66a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
- Coverage   23.52%   23.18%   -0.35%     
==========================================
  Files           4        4              
  Lines          68       69       +1     
==========================================
  Hits           16       16              
- Misses         52       53       +1     
Impacted Files Coverage Δ
src/recipes/gpsample.jl 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

github-actions bot and others added 3 commits October 13, 2022 14:10
…ep existing compat) (#44)

Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org>
…xisting compat) (#45)

Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org>
@devmotion devmotion merged commit 465d7f0 into main Oct 13, 2022
@devmotion devmotion deleted the compathelper/new_version/2022-10-13-11-59-13-828-03796872553 branch October 13, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants