Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI tests #28

Merged
merged 6 commits into from
Jan 8, 2022
Merged

Fix CI tests #28

merged 6 commits into from
Jan 8, 2022

Conversation

rossviljoen
Copy link
Contributor

Copies CI test setup from ApproximateGPs

@willtebbutt
Copy link
Member

Looks like the Window's runner doesn't have enough memory. I wonder whether the ubuntu failures are also caused by out-of-memory problems?

@rossviljoen
Copy link
Contributor Author

rossviljoen commented Jan 8, 2022

The last commit is showing up on the branch but not on this pr somehow?

Edit: ok now it is

@willtebbutt
Copy link
Member

willtebbutt commented Jan 8, 2022

The last commit is showing up on the branch but not on this pr somehow?

Maybe you need to rebase onto master? My git knowledge is bad. Either way, I wouldn't worry about it.

edit: ignore me.

@codecov
Copy link

codecov bot commented Jan 8, 2022

Codecov Report

Merging #28 (450d79f) into master (4302741) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #28   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           51        51           
=========================================
  Hits            51        51           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4302741...450d79f. Read the comment docs.

Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. I'm happy for this to go in when CI passes (looks like it's going to). I would imagine that the tests on the empirical covariance are probably still good enough to prevent any really bad bugs from creeping in, so probably 1_000 samples is fine.

@rossviljoen rossviljoen merged commit 0dd9735 into master Jan 8, 2022
@rossviljoen rossviljoen deleted the ross/ci-tests branch January 8, 2022 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants