-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI tests #28
Fix CI tests #28
Conversation
Looks like the Window's runner doesn't have enough memory. I wonder whether the ubuntu failures are also caused by out-of-memory problems? |
The last commit is showing up on the branch but not on this pr somehow? Edit: ok now it is |
edit: ignore me. |
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 51 51
=========================================
Hits 51 51 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. I'm happy for this to go in when CI passes (looks like it's going to). I would imagine that the tests on the empirical covariance are probably still good enough to prevent any really bad bugs from creeping in, so probably 1_000 samples is fine.
Copies CI test setup from ApproximateGPs