Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Categorical Likelihood #16

Merged
merged 7 commits into from
Sep 26, 2020
Merged

Add Categorical Likelihood #16

merged 7 commits into from
Sep 26, 2020

Conversation

sharanry
Copy link
Member

Adds categorical likelihood. This can be used along with MOInputs and MOKernels to model multi-class classification.

src/likelihoods/categorical.jl Outdated Show resolved Hide resolved
src/likelihoods/categorical.jl Outdated Show resolved Hide resolved
test/likelihoods/categorical.jl Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2020

Codecov Report

Merging #16 into master will increase coverage by 10.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #16       +/-   ##
===========================================
+ Coverage   62.50%   72.72%   +10.22%     
===========================================
  Files           3        4        +1     
  Lines           8       11        +3     
===========================================
+ Hits            5        8        +3     
  Misses          3        3               
Impacted Files Coverage Δ
src/GPLikelihoods.jl 100.00% <ø> (ø)
src/likelihoods/categorical.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b89c26...6991dd2. Read the comment docs.

@willtebbutt willtebbutt mentioned this pull request Sep 22, 2020
@devmotion
Copy link
Member

I'm not sure if @willtebbutt's intention was that #18 should be addressed before merging any of the open likelihood PRs?

@sharanry
Copy link
Member Author

I'm not sure if @willtebbutt's intention was that #18 should be addressed before merging any of the open likelihood PRs?

I thought he meant we address common tests before introducing anymore new likelihood PRs. I was waiting for these 2 PRs to get merged before starting on the TestUtils. Maybe I was mistaken.

@devmotion
Copy link
Member

I thought he meant we address common tests before introducing anymore new likelihood PRs.

I assume that's what he had in mind, but since I'm not completely sure I think it's good if we wait and let him comment on it.

@willtebbutt
Copy link
Member

I'm not particularly fussed what order this happens in, provided that no new PRs are opened without having the test utils sorted :)

@sharanry sharanry merged commit 3a540d9 into master Sep 26, 2020
@sharanry sharanry deleted the sharan/categorical branch September 26, 2020 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants