Add Heteroscedastic Gaussian Likelihood #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
==========================================
+ Coverage 62.50% 63.63% +1.13%
==========================================
Files 3 3
Lines 8 11 +3
==========================================
+ Hits 5 7 +2
- Misses 3 4 +1
Continue to review full report at Codecov.
|
devmotion
reviewed
Sep 17, 2020
theogf
reviewed
Sep 17, 2020
|
@devmotion @willtebbutt @theogf Any objections to merge this? |
devmotion
reviewed
Sep 22, 2020
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Closed
willtebbutt
approved these changes
Sep 22, 2020
There was a problem hiding this comment.
This broadly looks good to me, and I'm happy to see it merged.
I think that it's important that we address the issue I've just opened (#18 ) before pushing forward with any more likelihoods though, or our tests are quickly going to become unmaintainable.
|
Also, patch bump please :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.