Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement multiple parametrization for Negative Binomial #80

Merged
merged 36 commits into from
Apr 28, 2022

Conversation

theogf
Copy link
Member

@theogf theogf commented Apr 17, 2022

As discussed in #69, we need to be more flexible with the parametrization of NegativeBinomialLikelihood.
This is done here by having an extra parameter.
The interface is easily extended by defining a new type and two functions!

Also add docs to explain all this mess

There is still an issue with Functors.jl I will try to solve. But I thought I would already show the current status to get some feedback.

src/likelihoods/negativebinomial.jl Outdated Show resolved Hide resolved
test/likelihoods/negativebinomial.jl Outdated Show resolved Hide resolved
test/likelihoods/negativebinomial.jl Outdated Show resolved Hide resolved
theogf and others added 3 commits April 17, 2022 22:08
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
theogf and others added 3 commits April 19, 2022 10:20
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
theogf and others added 2 commits April 19, 2022 11:18
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@theogf theogf changed the title WIP: Implement multiple parametrization for Negative Binomial Implement multiple parametrization for Negative Binomial Apr 19, 2022
@theogf theogf requested a review from st-- April 19, 2022 09:18
src/likelihoods/negativebinomial.jl Outdated Show resolved Hide resolved
src/likelihoods/negativebinomial.jl Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #80 (4c8b4d7) into master (498af31) will increase coverage by 0.74%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
+ Coverage   95.76%   96.50%   +0.74%     
==========================================
  Files          10       10              
  Lines         118      143      +25     
==========================================
+ Hits          113      138      +25     
  Misses          5        5              
Impacted Files Coverage Δ
src/likelihoods/negativebinomial.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 498af31...4c8b4d7. Read the comment docs.

theogf and others added 5 commits April 19, 2022 12:13
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…sses/GPLikelihoods.jl into tgf/negative-binomial
src/GPLikelihoods.jl Outdated Show resolved Hide resolved
test/likelihoods/negativebinomial.jl Outdated Show resolved Hide resolved
theogf and others added 2 commits April 26, 2022 21:23
Co-authored-by: st-- <st--@users.noreply.github.com>
Co-authored-by: st-- <st--@users.noreply.github.com>
Copy link
Member

@st-- st-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; huge improvement!

Only thing you might want to add before merging is a comment on the parameter domains (i.e. successes and failures have to be positive, I think, \alpha definitely must be > 0 (will error for \alpha=0), don't know about \rho)?

@st--
Copy link
Member

st-- commented Apr 26, 2022

also, patch bump?

theogf and others added 7 commits April 26, 2022 22:52
Co-authored-by: st-- <st--@users.noreply.github.com>
Co-authored-by: st-- <st--@users.noreply.github.com>
Co-authored-by: st-- <st--@users.noreply.github.com>
Co-authored-by: st-- <st--@users.noreply.github.com>
Co-authored-by: st-- <st--@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants