Fix bug #40
Merged
Fix bug #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 98.06% // Head: 98.06% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #40 +/- ##
=======================================
Coverage 98.06% 98.06%
=======================================
Files 14 14
Lines 516 517 +1
=======================================
+ Hits 506 507 +1
Misses 10 10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
theogf
approved these changes
Jan 16, 2023
|
Essentially the implementation was just plain wrong, and was often terminating way before it should have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a nasty bug in the Cholesky code. This PR fixes it and adds a test which fails on master.