Break tests into different groups #323
Conversation
|
Maybe we could also drop tests on MacOS and Windows? There are no OS-specific features in KernelFunctions, so I don't think the additional tests provide any additional information. And if there are actually OS-specific bug reports at some we can still reevaluate. |
I am in favour of this. |
There was a problem hiding this comment.
Looks good to me. Just a thought, to minimise the risk of someone at some point introducing a typo in "All", how about changing it to GROUP = get(ENV, "GROUP", "") and then simply testing if GROUP == "" || ...? The intent is the same ("" == "no specific group").
|
@st-- I noticed that the coveralls requires some explicit handling of the parallel runs, otherwise the coverage reports are completely messed up. I just updated the action according to https://github.com/coverallsapp/github-action#complete-parallel-job-example. Can you re-approve if you are happy with the PR? |
|
The test error with the Julia nightly is caused by JuliaArrays/AxisArrays.jl#200 and not related to KernelFunctions. |
|
@devmotion why would coverage have decreased? does this mean some tests got missed out in the split ? |
|
I don't think the drop is real, I can't find any coverage changes in the more detailed output of coveralls. I assume it is just related to the change from non-parallel to parallel tests and uploads. |
Fixes #315.
Probably it can/should be optimized what groups and in particular how many of them we use.