CompatHelper: bump compat for "FillArrays" to "0.12" #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
theogf
force-pushed
the
compathelper/new_version/2021-07-09-00-40-19-538-2994191805
branch
from
9721615
to
bf4dba2
Compare
|
Seems to require this MichielStock/Kronecker.jl#96 |
|
We can try again once JuliaRegistries/General#40847 goes in and a new version of Kronecker.jl is tagged (turns out Kronecker.jl didn't need a FillArrays dependency at all, so it no longer has one!) |
…19-538-2994191805
|
any idea where the Zygote test failure might come from ? |
|
Well it's not the first time FBM is a complicated kid... |
Not sure, but I'm seeing them in #340 as well, so I think it's safe to conclude that it's not related to this PR. I don't think we should block this because of that. |
|
@theogf if you merge master in to this branch, the tests should now pass. |
theogf
approved these changes
Jul 21, 2021
theogf
deleted the
compathelper/new_version/2021-07-09-00-40-19-538-2994191805
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
FillArrayspackage from0.10, 0.11to0.10, 0.11, 0.12.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.