Use LIBSVM in SVM example #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's nice! At some point let's try to see if we can get an implementation with SimpleSVMs.jl @matbesancon |
|
Glad you approve @theogf . Are you happy to approve this in the mean time? |
theogf
reviewed
Jul 19, 2021
Co-authored-by: Théo Galy-Fajou <theo.galyfajou@gmail.com>
theogf
previously approved these changes
Jul 19, 2021
|
yes we could/should plumb the two together at some point |
st--
reviewed
Jul 19, 2021
st--
reviewed
Jul 19, 2021
Co-authored-by: st-- <st--@users.noreply.github.com>
st--
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed previously, our SVM example wasn't actually an SVM.
This PR utilises LIBSVM.jl to make it actually be an SVM.