Add docstring to kernelkronmat and small corrections
#377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theogf
changed the title
kernelkronmat and small corrections
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Crown421
reviewed
Oct 6, 2021
Crown421
approved these changes
Oct 6, 2021
devmotion
requested changes
Oct 6, 2021
|
@willtebbutt @devmotion Given that I restricted the function signatures and removed a meaningless kwarg, should that be considered breaking? |
|
My inclination is to say that this should not be considered breaking -- the restriction is probably a bug fix, and the meaningless kwarg feels like a bug. @devmotion what are your thoughts? |
devmotion
reviewed
Oct 8, 2021
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
st--
reviewed
Oct 15, 2021
Co-authored-by: st-- <st--@users.noreply.github.com>
devmotion
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
kernelkronmatkernelkronmatobsdimkwarg@assertstatements byerroriskroncompatibledocstringProposed changes
Following #369 I wanted to take care of moving
kernelpdmatin the right place and add a docstring tokernelkronmatWhat alternatives have you considered?
Deleting
kernelkronmatBreaking changes
I added stronger requirements on the
kernelkronmatwhich might be considered breaking...