Intersection points #164
Merged
Intersection points #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaqz
reviewed
Jun 21, 2024
src/methods/clipping/intersection.jl
Outdated
| line_orient == line_out && continue | ||
| pt1, _ = intr1 | ||
| push!(result, pt1) | ||
| if line_orient == line_over |
There was a problem hiding this comment.
We don't need to check line_cross or line_hinge any more?
There was a problem hiding this comment.
No. I will add comments, but if it is line_cross and line_hinge (and line_over), then we know there is one intersection point. Then, if it is line_over, we know that there is a second intersection points. This isn't true with line_hinge and line_cross.
asinghvi17
approved these changes
Jun 24, 2024
Co-authored-by: Anshul Singhvi <anshulsinghvi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the
intersection_pointsfunction just skipped degenerate intersection points. This might not be the most performant way to do this due to theunique!call, but at least it is more correct than the previous version.If approved, I can also do a patch version bump.