Try out Runic formatting #138
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
reviewed
Jul 13, 2024
Comment on lines
+7
to
+8
| LiveServer.servedocs( | ||
| ; |
There was a problem hiding this comment.
This look a bit stupid -- The ; should be directly after the opening ( I think.
There was a problem hiding this comment.
Yeah, that would be better
| @@ -20,6 +24,7 @@ function safe_include(filename) | |||
| end | |||
| const session_tmp = mktempdir() | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Did you manually insert all of these extra newlines? I am guessing this could be another Windows-related line ending bug if not.
There was a problem hiding this comment.
I didn't do anything after running the formatter. It looks like the bug since it looked fine originally https://github.com/JuliaGeometry/DelaunayTriangulation.jl/blob/main/docs/make.jl
| update_representative_point=update_representative_point, | ||
| store_event_history=store_event_history, | ||
| event_history=event_history, | ||
| is_true(peek) ? (new_point_x, new_point_y) : num_points(tri); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully doesn't break everything
Will have to update the files again after fredrikekre/Runic.jl#15 is addressed