Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lipschitz and Hurwitz quaternions #45

Closed
chrisvwx opened this issue Mar 29, 2021 · 4 comments · Fixed by #134
Closed

Lipschitz and Hurwitz quaternions #45

chrisvwx opened this issue Mar 29, 2021 · 4 comments · Fixed by #134

Comments

@chrisvwx
Copy link

My understanding is that the current implementation of Quaternions with Int inputs is aligned with the idea of a Lipschitz quaternion.

julia> Quaternion(1,2,3,4)
Quaternion{Int64}(1, 2, 3, 4, false)

On the other hand, in many cases one wants a Hurwitz quaternion. Even though I don't have a clear idea how a Hurwitz quaternion would be integrated with this package, I thought perhaps an issue about it would at least provide a place to discuss the topic.

@chakravala
Copy link

i think the obvious solution is to implement another "<:Real" type which stores an integer, but divides it by 2 and prints it, and then use that as coefficients

chakravala added a commit to chakravala/HalfIntegers.jl that referenced this issue Mar 29, 2021
@chakravala
Copy link

Alright, I went ahead and created the https://github.com/chakravala/HalfIntegers.jl package, let me know if you try it.

@chakravala
Copy link

Apparently there is another existing repository doing the same thing https://github.com/sostock/HalfIntegers.jl

@hyrodium
Copy link
Collaborator

hyrodium commented Apr 9, 2022

I think this issue is solved with HalfIntegers.jl. It would be nice to have more documentation for Hurwitz quaternions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants