Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Octonion #100

Merged
merged 6 commits into from
Oct 6, 2022
Merged

Remove Octonion #100

merged 6 commits into from
Oct 6, 2022

Conversation

hyrodium
Copy link
Collaborator

This PR removes Octonion type. (closes #90)

I did not update the documentation not to make conflicts with #92.

@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #100 (f260c92) into master (5758dad) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #100   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         1    -1     
  Lines          287       197   -90     
=========================================
- Hits           287       197   -90     

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hyrodium
Copy link
Collaborator Author

hyrodium commented Oct 6, 2022

This PR is ready for review.

@hyrodium hyrodium requested a review from sethaxen October 6, 2022 07:15
Copy link
Collaborator

@sethaxen sethaxen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more code deletions.

src/Quaternions.jl Outdated Show resolved Hide resolved
src/Quaternions.jl Outdated Show resolved Hide resolved
hyrodium and others added 3 commits October 6, 2022 18:50
Co-authored-by: Seth Axen <seth@sethaxen.com>
Co-authored-by: Seth Axen <seth@sethaxen.com>
@hyrodium hyrodium merged commit d15ad86 into JuliaGeometry:master Oct 6, 2022
@hyrodium hyrodium mentioned this pull request Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split Octonion into another package?
2 participants