Subdivide tests and rewrite try/catch/continue #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continue statements in tests cause problems (JuliaLang/julia#17908)
|
Changes Unknown when pulling 7a04d03 on swt30:fix-tests into * on JuliaGeometry:master*. |
|
Tests should now work on julia 0.5 once a new GeometricalPredicates is tagged. |
|
Changes Unknown when pulling b98c79c on swt30:fix-tests into * on JuliaGeometry:master*. |
swt30
changed the title
Closes #24
swt30
changed the title
|
Changes Unknown when pulling 0c541f6 on swt30:fix-tests into * on JuliaGeometry:master*. |
|
Merged, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue statements in tests cause problems (JuliaLang/julia#17908) so I rewrote those, split the tests into individual test sets, and added a missing import. The tests now work on julia 0.4, but 0.5 still has issues.