Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix show method for Signal #185

Merged
merged 1 commit into from Aug 30, 2018
Merged

fix show method for Signal #185

merged 1 commit into from Aug 30, 2018

Conversation

piever
Copy link

@piever piever commented Aug 30, 2018

Otherwise show would throw on a Signal with value nothing.

@SimonDanisch
Copy link
Member

should we use repr here?

@piever
Copy link
Author

piever commented Aug 30, 2018

Not sure:

julia> s = "test";

julia> repr(s)
"\"test\""

julia> s == repr(s)
false

With repr we'd show all strings with the '\"' character.

@SimonDanisch SimonDanisch merged commit 3365626 into master Aug 30, 2018
@SimonDanisch SimonDanisch deleted the pv/print branch August 30, 2018 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants