Skip to content

Commit

Permalink
Update find_jupyter_cmd for Conda.jl on Windows. (#354)
Browse files Browse the repository at this point in the history
* Correction to the function find_jupyter_cmd to fix problem on Windows installations based on miniConda
  • Loading branch information
kobussch authored and twavv committed Oct 15, 2019
1 parent 673785d commit 888f0b4
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion deps/jupyter.jl
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,12 @@ function find_jupyter_cmd(; force_conda_jupyter::Bool=false)::Cmd
# This is a heuristic - it might be different. I'm not sure that there's
# an easy way to load Conda.jl (I tried adding it to extras but no dice).
conda_root = joinpath(first(Base.DEPOT_PATH), "conda", "3")
jupyter = joinpath(conda_root, "bin", "jupyter")
@static if Sys.iswindows()
jupyter = joinpath(conda_root, "Scripts", "jupyter.exe")
else
jupyter = joinpath(conda_root, "bin", "jupyter")
end

if isfile(jupyter)
return `$jupyter`
end
Expand Down

0 comments on commit 888f0b4

Please sign in to comment.