Skip to content

Commit

Permalink
Pin NPM version for build-time download
Browse files Browse the repository at this point in the history
  • Loading branch information
@twavv
twavv committed Sep 13, 2021
1 parent 137a1a0 commit 95f5b9c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
2 changes: 0 additions & 2 deletions deps/build.jl
View file
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
using JSON

include("./bundlepaths.jl")
include("./jupyter.jl")

download_js_bundles()

const CONFIG_BEGIN_MARKER = "###JULIA-WEBIO-CONFIG-BEGIN"
Expand Down
10 changes: 5 additions & 5 deletions deps/bundlepaths.jl
View file
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
using Pkg.TOML

const WEBIO_VERSION = let
project_file = normpath(joinpath(@__DIR__, "..", "Project.toml"))
project = TOML.parsefile(project_file)
VersionNumber(project["version"])
end
# Fix the NPM version for now
# Now that we're not distributing Jupyter stuff via NPM, I'd rather just check
# in compiled assets (maybe using Artifacts if that's relatively easy, otherwise
# just as files in git).
const WEBIO_VERSION = "0.8.15"

const PACKAGES_PATH = normpath(joinpath(@__DIR__, "..", "packages"))
const BUNDLES_PATH = normpath(joinpath(@__DIR__, "bundles"))
Expand Down

5 comments on commit 95f5b9c

@twavv
Copy link
Member Author

@twavv twavv commented on 95f5b9c Sep 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request updated: JuliaRegistries/General/44808

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.8.16 -m "<description of version>" 95f5b9c87e0993fc2f87ccad358526dbf2dc42d2
git push origin v0.8.16

@hhaensel
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see two different versions in Project.toml and bundlepath.jl. Is that by purpose?

@twavv
Copy link
Member Author

@twavv twavv commented on 95f5b9c Sep 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I've decided that I don't want to continue publish packages to NPM and then downloading them at build time. Until we get around to fixing that, it's downloading 0.8.15 which is the last release to NPM. No changes have been made to that JS code anyway so it's fine.

@hhaensel
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification, understood now 😃

Please sign in to comment.