Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not Compatible with JupyterLab 2.0.0 #397

Closed
xgdgsc opened this issue Mar 22, 2020 · 19 comments
Closed

Not Compatible with JupyterLab 2.0.0 #397

xgdgsc opened this issue Mar 22, 2020 · 19 comments

Comments

@xgdgsc
Copy link

xgdgsc commented Mar 22, 2020

The bug

install_jupyter_labextension() fails

Context

┌ Info: Using default Jupyter executable at `/mnt/dev/home/gsc/anaconda3/envs/jl/bin/jupyter`; to use a different executable, see the documentation by running `?WebIO.install_jupyter_labextension`.
└ @ WebIO /home/gsc/.julia/packages/WebIO/2mZPb/deps/jupyter.jl:141
An error occured.
ValueError: No linked package for @webio/webio
See the log file for details:  /tmp/jupyterlab-debug-nqubt68w.log
No labextension named "@webio/jupyter-lab-provider" installed
An error occured.
ValueError: 
"@webio/jupyter-lab-provider@0.8.11" is not compatible with the current JupyterLab
Conflicting Dependencies:
JupyterLab              Extension      Package
>=2.0.2 <2.1.0          >=1.0.1 <2.0.0 @jupyterlab/application
>=2.0.2 <2.1.0          >=1.0.1 <2.0.0 @jupyterlab/docmanager
>=2.0.2 <2.1.0          >=1.0.1 <2.0.0 @jupyterlab/notebook
>=2.0.2 <2.1.0          >=1.0.1 <2.0.0 @jupyterlab/rendermime
>=5.0.2 <5.1.0          >=4.0.1 <5.0.0 @jupyterlab/services
See the log file for details:  /tmp/jupyterlab-debug-mrq4jl6f.log
failed process: Process(`/mnt/dev/home/gsc/anaconda3/envs/jl/bin/jupyter labextension install --no-build @webio/jupyter-lab-provider@0.8.11`, ProcessExited(1)) [1]


Stacktrace:
 [1] pipeline_error at ./process.jl:525 [inlined]
 [2] #run#565(::Bool, ::typeof(run), ::Cmd) at ./process.jl:440
 [3] run at ./process.jl:438 [inlined]
 [4] #install_jupyter_labextension#66(::Bool, ::Bool, ::typeof(WebIO.install_jupyter_labextension), ::Nothing) at /home/gsc/.julia/packages/WebIO/2mZPb/deps/jupyter.jl:159
 [5] install_jupyter_labextension(::Nothing) at /home/gsc/.julia/packages/WebIO/2mZPb/deps/jupyter.jl:139 (repeats 2 times)
 [6] top-level scope at In[10]:2

Info:

JupyterLab v2.0.1
No installed extensions
[0f1e0344] WebIO v0.8.11
Julia Version 1.3.1
Commit 2d5741174c (2019-12-30 21:36 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
  CPU: Intel(R) Xeon(R) CPU E5-2683 v3 @ 2.00GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-6.0.1 (ORCJIT, haswell)
@twavv
Copy link
Member

twavv commented Mar 23, 2020

The extension hasn't been updated for JupyterLab 2.0 yet. An immediate workaround would be to downgrade to JupyterLab v1 series.

@twavv twavv changed the title install_jupyter_labextension() fails Not Compatible with JupyterLab 2.0.0 Apr 10, 2020
twavv added a commit that referenced this issue Apr 17, 2020
This is a workaround for #397 which causes tests to fail, but isn't a fix in that WebIO still isn't compatible with JupyterLab v2.
@bjornarfjelldal
Copy link

Hi! Is the latest workaround still to downgrade Jupyterlab to v1 series?

@twavv
Copy link
Member

twavv commented May 14, 2020

Yes.

I’m not sure how much has changed for extensions between 1 and 2 and haven’t had time to look at it yet unfortunately.

@isentropic
Copy link

Hello, do you think this would work even if compatibility is disregarded?
Many people probably need new jupyterlab for other python issues

@lcontento
Copy link
Contributor

Hi! Looking at the migration guide https://jupyterlab.readthedocs.io/en/stable/developer/extension_migration.html, I tried making the minimum number of changes needed for WebIO to run with JupyterLab 2.x. You can see them at master...lcontento:master. On my machine it appears basic functionality is restored, but maybe more work is still needed... Hope it may be useful (at least as a stopgap solution).

@isentropic
Copy link

Great, perhaps we could expect a PR sometime soon?

@bollwyvl
Copy link

@lcontento I have been using your branch over in a demo binder (repo) running JupyterLab 2.2.0 (and a lot of other stuff)... from a Julia perspective, while I can't seem to get LanguageServer.jl working properly, everything else is looking pretty good!

@barche
Copy link

barche commented Aug 31, 2020

Any chance the changes from @lcontento could be distilled into a PR and merged? We are also using this to make WebIO work on a recent jupyterlab installation in jupyterhub.

@lcontento
Copy link
Contributor

Any chance the changes from @lcontento could be distilled into a PR and merged? We are also using this to make WebIO work on a recent jupyterlab installation in jupyterhub.

I could try starting a PR with my changes, but I am not familiar enough with the code base to say whether additional changes need to be made. It would be best if after I start the PR one of the maintainers took over it.

@twavv
Copy link
Member

twavv commented Sep 1, 2020

Open a PR and I can try to find a few spare hours to look it over.

@jlumpe
Copy link
Contributor

jlumpe commented Sep 27, 2020

@lcontento what is the installation process to try out your changes?

@lcontento
Copy link
Contributor

@lcontento what is the installation process to try out your changes?

If I remember correctly it was quite straightforward. I don't think you need to install my version through the Julia package manager (the official package should work just fine, since I did not touch the Julia code). Just cloning my repository and running jupyter-labextension install /path/to/lcontento/WebIO/packages/jupyter-lab-provider should be enough.

@Krisselack
Copy link

@lcontento

If I remember correctly it was quite straightforward. I don't think you need to install my version through the Julia package
manager (the official package should work just fine, since I did not touch the Julia code). Just cloning my repository and running > jupyter-labextension install /path/to/lcontento/WebIO/packages/jupyter-lab-provider should be enough.

I got the following error

ValueError: "./WebIO.jl/packages/jupyter-lab-provider" is not a valid extension:
Missing extension module "dist/labextension.js"

@lcontento
Copy link
Contributor

I got the following error

ValueError: "./WebIO.jl/packages/jupyter-lab-provider" is not a valid extension:
Missing extension module "dist/labextension.js"

I thought that this issue would have been closed after #430 was merged.
I have not been using WebIO in a while, maybe something has changed in the extension format for the 2. series (or maybe my migration was not perfect in the beginning).
I am sorry, but at the moment I don't really have the extra time to look into this.
And anyway JupyterLab 3 is already out, so a new migration will be in order soon I suppose...

@Krisselack
Copy link

Thank you for the fast response! Yes, indeed I have Jupyterlab 3.... no wonder :-)

@bollwyvl
Copy link

bollwyvl commented Feb 17, 2021 via email

@Krisselack
Copy link

There is a new issue open...
#442

@jlumpe
Copy link
Contributor

jlumpe commented Feb 27, 2021

@Krisselack are you using dev=true with install_juypter_labextension? I was getting the same "Missing extension module" error as well when doing that, but it worked without that on jupyterlab 2.2.6.

@Krisselack
Copy link

Thank you, I tried that with the following result:

An error occured.
ValueError: "/opt/julia/packages/WebIO/Fy9h1/packages/jupyter-lab-provider" is not a valid extension:
Missing extension module "dist/labextension.js"

@twavv twavv closed this as completed Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants