Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't prevent an update if the value doesn't change #149

Merged
merged 1 commit into from
Jun 28, 2018
Merged

Conversation

shashi
Copy link
Member

@shashi shashi commented Jun 27, 2018

This is necessary to get Knockout to work properly if I understand correctly. cc @piever

This makes JuliaGizmos/Vue.jl#10 necessary. We should release them both in tandem.

closes #39 against @JobJob's will?? :-P Let me know if you still think we really need this check here! My reasoning is here

@piever
Copy link
Collaborator

piever commented Jun 27, 2018

I think Knockout can somehow be patched to workaround this (like in Vue.jl, by always making a copy of the whole object that's synced between Knockout and WebIO) but I somehow feel it's strange to have different semantics between WebIO Observables and Julia Observables (especially as there is no way to forcefully "trigger" an update right now).

@JobJob
Copy link
Member

JobJob commented Jun 27, 2018

I think all the arguments in favour of this seem sensible.

I have a nagging feeling that there was a case that made me want to use the "don't update unless changed" semantic, but since I can't think of it, we should merge this.

@shashi shashi merged commit c7ebf97 into master Jun 28, 2018
@shashi shashi deleted the s/comm-fixes branch June 28, 2018 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow updates with the same value
3 participants