Fix from source builds for Julia version < 1.0 #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
The reason to comment the lines out was a failure on 1.0 in line 128. Since I have 0 BinDeps experience I was not able debugging it. |
|
The Windows SimpleBuild can be removed, that's not so useful. The unix one is important. |
|
Yeah this looks workable. Haven't checked the CI logs here, does this solve the issue in its current state? |
|
@tkelman: I have now a version where the Source builds should also work on 1.0. CI is passing. I just had do disable the SimpleBuild on 1.0. Please merge if you are satisfied. |
|
Is that replace syntax available in the Compat version matching the require lower bound? |
|
certainly not. Should I bump to the most recent one (1.0.1)? |
|
no, it was 0.43 JuliaLang/Compat.jl@e450796 so that's fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tkelman: Sorry for being too quick. Could you please review, merge this one and initiate a release if this fixed the issue with the from source builds.