Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update binaries #303

Merged
merged 7 commits into from
Oct 13, 2019
Merged

Conversation

davidanthoff
Copy link
Contributor

@davidanthoff davidanthoff commented Oct 11, 2019

This updates the binaries we are using to versions that work with a BP based Rsvg.jl as it is in lobingera/Rsvg.jl#35.

I increment the version of the package here because I think we should treat changes like this as breaking.

@coveralls
Copy link

coveralls commented Oct 11, 2019

Coverage Status

Coverage remained the same at 91.348% when pulling 2167096 on davidanthoff:update-binaries into 01c35c6 on JuliaGraphics:master.

@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #303 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #303   +/-   ##
=======================================
  Coverage   92.16%   92.16%           
=======================================
  Files           1        1           
  Lines         434      434           
=======================================
  Hits          400      400           
  Misses         34       34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01c35c6...2167096. Read the comment docs.

@davidanthoff
Copy link
Contributor Author

Alright, so the big three all seem to work, but FreeBSD and the drone build don't. I'm a bit at a loss what is going on there. @staticfloat and @giordano, any idea?

@davidanthoff
Copy link
Contributor Author

Hurray, it all seems to work!

@lobingera could you merge and then tag a release, v0.8.0? Once that is done, we should be able to finish the Rsvg.jl conversion to BinaryProvider as well :)

@@ -46,4 +47,4 @@ if unsatisfied || !isinstalled(dl_info...; prefix=prefix)
end

# Write out a deps.jl file that will contain mappings for our products
write_deps_file(joinpath(@__DIR__, "deps.jl"), products, verbose=verbose)
write_deps_file(joinpath(@__DIR__, "deps.jl"), products, verbose=verbose)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline here 🙂

@@ -44,4 +47,4 @@ if unsatisfied || !isinstalled(dl_info...; prefix=prefix)
end

# Write out a deps.jl file that will contain mappings for our products
write_deps_file(joinpath(@__DIR__, "deps.jl"), products, verbose=verbose)
write_deps_file(joinpath(@__DIR__, "deps.jl"), products, verbose=verbose)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing new line

@lobingera lobingera merged commit 15706f2 into JuliaGraphics:master Oct 13, 2019
@davidanthoff davidanthoff deleted the update-binaries branch October 13, 2019 16:59
@davidanthoff
Copy link
Contributor Author

Thanks! @lobingera can you also tag a new release?

@lobingera
Copy link
Contributor

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Pull request comments will not trigger Registrator as it is disabled. Please trying using a commit or issue comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants