-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update binaries #303
Update binaries #303
Conversation
Codecov Report
@@ Coverage Diff @@
## master #303 +/- ##
=======================================
Coverage 92.16% 92.16%
=======================================
Files 1 1
Lines 434 434
=======================================
Hits 400 400
Misses 34 34 Continue to review full report at Codecov.
|
Alright, so the big three all seem to work, but FreeBSD and the drone build don't. I'm a bit at a loss what is going on there. @staticfloat and @giordano, any idea? |
Update X11 builder
Hurray, it all seems to work! @lobingera could you merge and then tag a release, v0.8.0? Once that is done, we should be able to finish the Rsvg.jl conversion to BinaryProvider as well :) |
@@ -46,4 +47,4 @@ if unsatisfied || !isinstalled(dl_info...; prefix=prefix) | |||
end | |||
|
|||
# Write out a deps.jl file that will contain mappings for our products | |||
write_deps_file(joinpath(@__DIR__, "deps.jl"), products, verbose=verbose) | |||
write_deps_file(joinpath(@__DIR__, "deps.jl"), products, verbose=verbose) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing newline here 🙂
@@ -44,4 +47,4 @@ if unsatisfied || !isinstalled(dl_info...; prefix=prefix) | |||
end | |||
|
|||
# Write out a deps.jl file that will contain mappings for our products | |||
write_deps_file(joinpath(@__DIR__, "deps.jl"), products, verbose=verbose) | |||
write_deps_file(joinpath(@__DIR__, "deps.jl"), products, verbose=verbose) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing new line
Thanks! @lobingera can you also tag a new release? |
@JuliaRegistrator register |
Pull request comments will not trigger Registrator as it is disabled. Please trying using a commit or issue comment. |
This updates the binaries we are using to versions that work with a BP based Rsvg.jl as it is in lobingera/Rsvg.jl#35.
I increment the version of the package here because I think we should treat changes like this as breaking.