Support Colors 0.12 #317
Merged
Support Colors 0.12 #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Allowed failure on nightly is fixed already by ColorTypes 0.10.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested this locally and it passes tests. In the Travis logs it's worth checking whether it actually uses this version, though.
We might want to install https://github.com/bcbi/CompatHelper.jl, though JuliaRegistries/CompatHelper.jl#160 is pretty annoying. But since Cairo's dependencies are pretty minimal, I doubt it will be that much of a problem here (it comes up much more often in packages with lots of dependencies).