Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for julia 0.7 #105

Merged
merged 1 commit into from Jun 20, 2018
Merged

fixes for julia 0.7 #105

merged 1 commit into from Jun 20, 2018

Conversation

fredrikekre
Copy link
Contributor

No description provided.

@fredrikekre
Copy link
Contributor Author

requires JuliaMath/FixedPointNumbers.jl#110 to pass tests

@fredrikekre
Copy link
Contributor Author

Ok, FixedPointNumbers is merged and tagged, should pass CI now.

Copy link

@ararslan ararslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here suggest that dropping 0.6 support isn't strictly necessary, but might as well I guess.

@codecov-io
Copy link

codecov-io commented Jun 20, 2018

Codecov Report

Merging #105 into master will increase coverage by 0.43%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
+ Coverage   99.28%   99.71%   +0.43%     
==========================================
  Files           5        5              
  Lines         417      348      -69     
==========================================
- Hits          414      347      -67     
+ Misses          3        1       -2
Impacted Files Coverage Δ
src/operations.jl 100% <ø> (ø) ⬆️
src/traits.jl 100% <100%> (+2.09%) ⬆️
src/types.jl 99.16% <100%> (-0.84%) ⬇️
src/show.jl 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edcef68...f9183e4. Read the comment docs.

@timholy timholy merged commit 307b7ae into JuliaGraphics:master Jun 20, 2018
@timholy timholy mentioned this pull request Jun 20, 2018
@fredrikekre fredrikekre deleted the fe/0.7 branch June 20, 2018 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants