Add promotions between Gray and multi-component Colorants #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These have been present since 2015-08-14; more than 1 year seems like plenty of time
|
That would be the more cautious option, yeah. Any idea if people had been using the old names in packages that weren't updated? |
|
I have 26 of the 52 Colors dependents installed. grepping all the |
timholy
changed the title
timholy
force-pushed
the
teh/promotion
branch
from
0f425f6
to
3f54b19
Compare
timholy
force-pushed
the
teh/promotion
branch
from
3f54b19
to
bbfaf7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amazing that we haven't noticed the lack of these previously. These rules aren't perfect, but I'll file an issue detailing what needs to improve.
@tkelman, I also noticed some stale (>1 year old)
@deprecatestatements, which I deleted. Does deleting those mean we need to do a minor version bump?