Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PyPlot example #415

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Conversation

kimikage
Copy link
Collaborator

@kimikage kimikage commented Apr 8, 2020

This changes the image format from PNG to SVG, and makes its colors dynamically set.

This changes the image format from PNG to SVG, and makes its colors dynamically set.
@kimikage kimikage mentioned this pull request Apr 8, 2020
28 tasks
@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #415 into master will decrease coverage by 1.40%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #415      +/-   ##
==========================================
- Coverage   82.46%   81.06%   -1.41%     
==========================================
  Files          10       10              
  Lines         867      882      +15     
==========================================
  Hits          715      715              
- Misses        152      167      +15     
Impacted Files Coverage Δ
src/utilities.jl 88.40% <0.00%> (-5.45%) ⬇️
src/algorithms.jl 59.81% <0.00%> (-2.94%) ⬇️
src/parse.jl 92.85% <0.00%> (-1.35%) ⬇️
src/display.jl 98.82% <0.00%> (-1.18%) ⬇️
src/differences.jl 31.46% <0.00%> (-0.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cb350b...3b6cd19. Read the comment docs.

@kimikage
Copy link
Collaborator Author

kimikage commented Apr 8, 2020

It looks like the sample numbers are different between the actual plot and the script.

and it is 0.9MB! 😅

docs/src/assets/figures/pyplot-seed-dcols.png PNG 1748x1026 1748x1026+0+0 8-bit sRGB 874257B

Of course, it is another option to generate the plot dynamically using PyPlot. However, the technical points of that example are to use the seed option and to convert the colors to arrays (cf. #298 (comment)), so I don't think the plotting result other than its colors is important.

@kimikage kimikage merged commit 646f45c into JuliaGraphics:master Apr 8, 2020
@kimikage kimikage deleted the docs_pyplot branch April 8, 2020 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants