Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ssh key for TagBot.yml #444

Merged
merged 1 commit into from
Sep 19, 2020
Merged

Add ssh key for TagBot.yml #444

merged 1 commit into from
Sep 19, 2020

Conversation

timholy
Copy link
Member

@timholy timholy commented Sep 19, 2020

Closes #443

Hopefully I did all the steps correctly...if not, let me know.

@codecov
Copy link

codecov bot commented Sep 19, 2020

Codecov Report

Merging #444 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #444   +/-   ##
=======================================
  Coverage   92.64%   92.64%           
=======================================
  Files          10       10           
  Lines         952      952           
=======================================
  Hits          882      882           
  Misses         70       70           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c88f062...61cb8ec. Read the comment docs.

Copy link
Member

@johnnychen94 johnnychen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We wouldn't know until there's a new release 😆

A manual way to fix things is to manually create and force-push a tag.

@timholy timholy merged commit 1bee0ac into master Sep 19, 2020
@timholy timholy deleted the teh/fix-443 branch September 19, 2020 11:40
@@ -9,3 +9,4 @@ jobs:
- uses: JuliaRegistries/TagBot@v1
with:
token: ${{ secrets.GITHUB_TOKEN }}
ssh: ${{ secrets.TagBot }}
Copy link
Member

@johnnychen94 johnnychen94 Sep 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably should be secrets.TAGBOT because GitHub seems to force uppercase for all its secrets. Unsure whether this version works.

Edit: I've updated it in 86d8e36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

configure SSH key for TagBot and optionally for CompatHelper
2 participants