Implement showable to check that all components are finite
#470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful to avoid conversion errors in advance. Since `NaN`/`Inf` may be caused by bugs, implicit clamping is not performed.
Codecov Report
@@ Coverage Diff @@
## master #470 +/- ##
==========================================
+ Coverage 90.50% 90.54% +0.03%
==========================================
Files 9 9
Lines 948 952 +4
==========================================
+ Hits 858 862 +4
Misses 90 90
Continue to review full report at Codecov.
|
johnnychen94
approved these changes
Apr 10, 2021
|
If this is urgent, you can release v0.12.8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful to avoid conversion errors in advance.
Since
NaN/Infmay be caused by bugs, implicit clamping is not performed. This is in contrast to clamping for out-of-gamut colors.Closes #469.