make sure value wrapped in mutable is not garbage collected (#682)

Co-authored-by: Kristoffer Carlsson <kcarlsson89@gmail.com> Co-authored-by: Valentin Churavy <vchuravy@mit.edu>
JuliaGraphics · Dec 27, 2022 · c3828bd · c3828bd · timholy · Dec 27, 2022
1 parent 57c3bfe
commit c3828bd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,6 +1,6 @@
 name = "Gtk"
 uuid = "4c0ca9eb-093a-5379-98c5-f87ac0bbbf44"
-version = "1.2.2"
+version = "1.2.3"
 
 [deps]
 Cairo = "159f3aea-2a34-519c-b102-8c37f9878175"

diff --git a/src/GLib/MutableTypes.jl b/src/GLib/MutableTypes.jl
@@ -34,8 +34,8 @@ mutable(x::Ptr{T}, i = 1) where {T} = x + (i - 1) * sizeof(T)
 mutable(x::T, i) where {T} = (i == 1 ? mutable(x) : error("Object only has one element"))
 
 _addrof(b::T) where {T} = pointer_from_objref(b)
-Base.cconvert(::Type{P}, b::MutableX{T}) where {P <: Ptr, T} = isbitstype(T) ? convert(P, _addrof(b)) : convert(P, _addrof(b.x))
-Base.cconvert(::Type{P}, b::MutableA{T, N}) where {P <: Ptr, T, N} = convert(P, pointer(b.x, b.i))
+Base.unsafe_convert(::Type{P}, b::MutableX{T}) where {P <: Ptr, T} = isbitstype(T) ? convert(P, _addrof(b)) : convert(P, _addrof(b.x))
+Base.unsafe_convert(::Type{P}, b::MutableA{T, N}) where {P <: Ptr, T, N} = convert(P, pointer(b.x, b.i))
 
 deref(b::Ptr) = unsafe_load(b)
 deref(b::MutableX) = b.x